Phase 2: add ts-frontend and ts-backend stacks to core:setup-repo - #13
Merged
Conversation
Replace vitest.config.ts with a Vite+Vitest vite.config.ts, add index.html and src/main.tsx so the ts-frontend stack scaffolds a working `npm run dev`/`build` React app instead of a config-only package. Update the scaffold engine and validators accordingly, and add tests/setup-repo/test-node-assets.sh to the repo's CI test suite.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends
core:setup-repowith the TypeScript stacks, so the scaffolder covers the org's TS repos as well as Python. Closes #6.What's added
vite.config.ts,index.html,src/main.tsx, plus a sample module + test.ci-node.yml—setup-node(node 20, npm cache) →npm ci→ typecheck → lint → test.scaffold-repo.shnow acceptsts-frontend/ts-backend(dispatch + up-front validation, non-clobber,gitignore→.gitignore,ci-node.yml→.github/workflows/ci.yml).package.json/tsconfig.json→ asks frontend vs backend; installs TS deps withnpm install.0.3.0 → 0.4.0(org-wide update signal).setup-repo-tests.ymlnow also runstest-node-assets.sh.npm (not yarn/pnpm/bun); versions mirror the Tower-Finder frontends. Out of scope: Phase 3 (pre-commit, C++).
Verification
test-python-assets,test-ci-assets,test-node-assets,test-scaffold) andclaude plugin validate .passes.npm install(clean, no peer/ERESOLVE issues) →npm run build(ts-frontendvite buildproducesdist/) →typecheck→lint→testall green.Process
Built subagent-driven: fresh implementer per task, per-task spec+quality review with fixes, then an Opus whole-branch review. The final review caught that ts-frontend's
dev/buildwere broken out of the box (no Vite entry) — fixed here so the frontend scaffold actually runs.🤖 Generated with Claude Code