Map: out-of-town stations sit at the station, not the city centre - #77
Merged
Merged
Conversation
…their own station
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
3/10, low
On the map, Lyon St-Exupéry TGV sits in the middle of Lyon, 19 km from the airport. Eleven more stations outside their town sit at its centre or on another station, up to 11.5 km off: Nîmes Pont-du-Gard, Les Arcs-Draguignan, Besançon Franche-Comté TGV, Valence TGV, Valence Ville, Calais-Fréthun, Le Creusot TGV, Nurieux, Mâcon-Loché TGV, Montpellier Sud-de-France and Avignon Centre. St-Pierre-des-Corps shares one point with Tours and Marseille Blancarde with St-Charles, so the nearby search never offers one from the other, and Les Aubrais sits 2.8 km off.
A station missing from
data/stations.jsontakes the position of the first city reference its name starts with, inmatchCity, soLYON ST EXUPERY TGV.lands on Lyon. Aliases such asmacon locheandsaint pierre des corpspinned others to their town, and theVALENCE TGVentry held a point that is neither Valence station.Each now has its own entry at the position SNCF publishes in its gares-de-voyageurs dataset, with the town kept as
cityso the Wikivoyage link still opens it. A new entry'scityalso takes the bare town key, so the Calais town row now carries the aliascalais villeto keep Calais Ville at the town. Against that dataset, no station outside the Paris, Lyon and Lille groups sits more than 2.3 km from its real position, over the 175 of 199 whose name matched.The name fallback stays, so a station added to the timetable later lands on its town again until it gets an entry.