Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 27 additions & 1 deletion scripts/verify-render.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
*
* Serves ./dist and loads it in headless Chromium (home + a deep-link). Fails
* (exit 1) if #app stays effectively empty or any uncaught page error fires, so
* a build that would show a blank page can never reach production.
* a build that would show a blank page can never reach production. It also
* fails when the controls in the phone header row differ in size.
*
* npm run build && npm run verify
*/
Expand Down Expand Up @@ -76,6 +77,31 @@ for (const { name, url } of pages) {
await page.close();
}

// Phone header: every visible control in the one-line row shares one height, and
// every control but the pass select shares one width.
const phone = await browser.newPage();
for (const width of [360, 390]) {
// Only a change of isMobile/hasTouch reloads the page; a width change reflows it.
await phone.setViewport({ width, height: 844, isMobile: true, hasTouch: true });
if (width === 360) {
await phone.goto(BASE, { waitUntil: "load", timeout: 45000 });
await phone.waitForSelector(".header-quick select");
}
const ctls = await phone.evaluate(() =>
[...document.querySelectorAll(".site-header .logo, .header-quick > *, .header-nav > .menu-btn")]
.map((e) => ({ e, r: e.getBoundingClientRect() }))
.filter(({ r }) => r.width > 0 && r.height > 0)
.map(({ e, r }) => ({ name: e.className || e.tagName, select: e.tagName === "SELECT", w: r.width, h: r.height })),
);
const spread = (xs) => Math.max(...xs) - Math.min(...xs);
const icons = ctls.filter((c) => !c.select);
const sizes = ctls.map((c) => `${c.name} ${c.w.toFixed(1)}x${c.h.toFixed(1)}`).join(", ");
if (spread(ctls.map((c) => c.h)) > 1) failures.push(`[header ${width}px] control heights differ: ${sizes}`);
if (spread(icons.map((c) => c.w)) > 1) failures.push(`[header ${width}px] icon button widths differ: ${sizes}`);
console.log(` header ${width}px: ${sizes}`);
}
await phone.close();

await browser.close();
server.close();

Expand Down
17 changes: 13 additions & 4 deletions src/styles.css
Original file line number Diff line number Diff line change
Expand Up @@ -4366,6 +4366,9 @@ select.input::-ms-expand {
.site-header {
flex-wrap: nowrap;
gap: 0.5rem;
/* One square size for the row. 184px is 53px of padding and gaps plus the
131px that fits "MAX SENIOR"; below 360px the squares shrink instead. */
--hdr-ctl: clamp(34px, (100vw - 184px) / 4, 44px);
}
.brand-badge {
display: none;
Expand All @@ -4392,13 +4395,19 @@ select.input::-ms-expand {
.header-quick select.ctl {
flex: 1;
min-width: 0;
min-height: 44px;
height: var(--hdr-ctl);
font-size: 0.95rem;
font-weight: 600;
}
.header-quick .icon-ctl {
width: 42px;
min-height: 44px;
/* Install carries no .icon-ctl and the menu sits outside .header-quick, so
each is named here beside Settings. */
.site-header .logo,
.header-quick .icon-ctl,
.header-quick .install-btn,
.header-nav > .menu-btn {
width: var(--hdr-ctl);
height: var(--hdr-ctl);
padding: 0;
flex: none;
}
.header-quick .install-label {
Expand Down
Loading