Conversation
A fixed 2 or 3 night stay graded days by any stay up to that length, so green days led to an empty return. The stay calendar now keeps the exact length unless the stay is flexible. Reverse same-day discovery now pairs the earliest arrival with the latest return home, as the forward search does, so no origin is lost and the hours on site match the trip. A train listed at two stations of one group keeps its shortest row. Browse and Ideas count trains from today only, and a card's time is the chosen day's. Discovery cards and trip rows show the exact time on site, and a stay's first return is the one the card counts. The form calendar follows days picked under the results. In Flexible, every range tap runs at once, so the header, date pill, URL and results agree; days before the departure are not offered as a return, the inert stepper reads the range, and the same-day minimum stays in place.
A stay's return list is fastest first again, and its first stays the default return. A stay's discovery card now counts that return, so its travel time matches the trip it opens. The first Flexible range tap stages the departure on the form again and runs nothing. It no longer rewrites the query, so the URL and the results keep the range on screen while the form header reads the departure as pending. The return tap runs the range.
# Conflicts: # src/app.ts
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
7/10, high
A green day, a count or a duration on a list could promise a trip that the page it opens does not have. Each section below is one place where the number and the trip disagreed; after this change every one of them is computed by the same sweep as the list it leads to.
This sits on the lists-links branch, #71, and merges after it. Every capture below is Chromium headless at 390px wide unless it names another width,
main5e514c5 on the left and this branch on the right.stayCalendar: a fixed stay's green day has no return
Paris to Lyon at 3 nights showed 17 green days, and 7 of them opened on an empty return list.
stayCalendargraded every stay withflexibleNights, so a day was green when any stay up to N nights worked. A fixed stay is now graded by exactly N nights: 10 green days, none empty.reverseGetawayIdeas: same-day discovery into a station loses origins
Into Lyon for the day on Sep 30 listed 5 origins and left out Valence, Montpellier and Paris, which the exact-trip page reaches with hours on site. The reverse search took the fastest outbound and whichever return came first. It now takes the earliest arrival and the latest return home, like the forward search: 13 origins that day.
dedupe: a train shows its slower arrival
Train 6627 reaches
LYON (intramuros)twice, at 19:54 and 20:10, and the list showed 20:10 becausededupekept whichever row came first in the data. It now keeps the shortest row of each chain, and that row is the one displayed and booked.windowStats and browse cards: counts and times from the wrong days
"This month" counted trains dated before today, since
windowStatstook the whole snapshot: Lille from Paris read 179 against 170 bookable. Browse cards showed the month's fastest time, not the chosen day's, and discovery cards rounded hours the trip then printed exactly. Counts now cover today onward, times are the chosen day's, and cards print the trip's own figure.The form calendar and Flexible mode: two answers on one screen
Picking a day on the results page left "When to leave?" on the old day, and in Flexible the header, the date and the results could each name a different range. A day pick now repaints the form calendar, and in Flexible the first tap reads as a pending departure until the return tap runs the range, with days before the departure grey meanwhile.
A discovery card now counts the time on site of the return the trip opens on, so the two figures agree. That costs a cold two-night list about 1.4 seconds more, since each card now runs the trip's own return search.