Multi-city: chain legs on arrival times and flag what cannot be taken - #70
Merged
Merged
Conversation
A custom leg now lists only the trains leaving at least 15 minutes after the previous leg's pick arrives, and re-picking a leg re-lists every later one. A leg with no such train, or dated before the previous arrival, stays open with a notice instead of a done mark. Every leg keeps its availability calendar, and the trip dialog dates each leg. Surprise me fills an empty trailing row from the previous leg's end instead of re-rolling leg 1, and picks a hop that leaves after that leg arrives, on the first day with one. Search stops on a leg or tour city naming no station and says so; an unknown city stays in its field. Leg fields, headers and city removers get proper names, the legs editor's links get a taller touch target, and the saved-tour dialog drops its map actions, which did nothing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
6/10, medium
Problem
A custom multi-city trip can show an itinerary nobody can travel as finished. Paris to Marseille then Marseille to Lille on the same day defaults leg 1 to 18:10 to 21:13 and leg 2 to 06:34, both ticked, and the trip dialog raises no conflict. Each leg picks its fastest train on its own, since 8f6941e, and the dialog only checks for a leg with no train at all.
"Surprise me" had the same blind spot and one more. With the last leg row empty it overwrote leg 1 instead of filling that row, so it never built a second leg, and the hops it did add took any train on the previous leg's date, arrival or not. Both come from c1b3d06.
Fix
A later leg lists only the trains leaving at least 15 minutes after the previous leg's pick arrives, the same margin the connection search uses, and picking another train re-lists every leg after it. A leg with nothing catchable stays open with a notice naming the arrival time and never gets its tick. Surprise fills the first row missing a destination and picks a hop leaving after the previous arrival, on the first day that has one.
Every leg now keeps its availability calendar, including when its day has no train, and the trip dialog dates each leg. Search stops on a leg or tour city naming no station instead of dropping it, the leg fields and headers get names a screen reader can announce, and the saved-tour dialog drops map buttons that did nothing.
Trains a leg cannot catch are hidden rather than greyed out, with a line saying they were. Each leg still defaults to its own fastest catchable train, so an earlier pick can leave a later leg empty where a slower one would not.