E2E: wait for the search to settle instead of sleeping 700ms - #66
Merged
Merged
Conversation
A re-search settles in 0.5 to 2.0 seconds against the committed snapshot, and the staged-edit scenario allowed 700ms, so the nightly deploy has been red since 14 August. Every assertion on search output now polls, and the scenario waits for the mounted UI in place of its 900ms settle. The staged edit also went into the origin field rather than the destination.
davd-gzl
marked this pull request as ready for review
August 20, 2026 06:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scheduled Pages deploy has not shipped since 14 August.
npm run test:e2efails one scenario,behaviour: a typed route edit stays staged until Search is clicked, on the same assertion every night:title did not update after Search.That scenario clicks Search, sleeps 700ms, then reads
#results-title. A re-search settles in 0.5 to 2.0 seconds against the committed snapshot: three consecutive local runs flipped the title after 456ms, 1253ms and 1999ms. The snapshot grew from 34,223 records in July to 55,466, which turned an occasional failure into a nightly one.Every assertion on search output now polls.
until()re-reads its condition every 100ms and gives up at 15 seconds, andscenario()waits for the mounted UI in place of its 900ms settle.Riding along, the scenario typed Lyon into the origin field rather than the destination.
.search-form .fields input[list="station-list"]matches the multi-city city box first, so index 1 is the origin; the edit now selects inside.od-fields. The assertion passed on a Lyon to Toulouse search, for a title that merely contained Lyon.