Descriptor Rework to Master#47
Draft
odudex wants to merge 2 commits into
Draft
Conversation
The previous approach walked each PR commit sequentially via
`git rebase --exec` on a single runner, which made N-commit PRs take
N× the runtime and failed outright when the base-branch fetch was
shallow (rebase couldn't resolve merge-base → replayed the whole repo
history). Replace it with the two-job pattern already used in liana
and bwk:
list-commits: enumerates (origin/$BASE..HEAD~] via `git log` and
emits a JSON array of {sha, name} objects on the
`commits` output.
check-commit: matrix-expanded from that JSON, one parallel job per
intermediate commit, each running the full
ci-checks.sh suite (format + tests + wave_4b build).
Per-job timeout drops from 360 min to 60 min since each runner now
handles a single commit. fail-fast: false so one bad commit doesn't
cancel the siblings.
Three constructors for the unified [Label][Item][?] settings row
shape used by Settings → Wallet:
settings_row_action (parent, label, on_click) — [>]
settings_row_dropdown(parent, label, options, sel,
on_change, help_title, help_msg) — [v][?]
settings_row_toggle (parent, label, initial,
on_change, help_title, help_msg) — [⚪][?]
Each row is one touch-target tall (theme_get_min_touch_size); the
trailing [?] glyph opens a help modal via dialog_show_info() with the
caption that previously wrapped under each toggle inline. Action rows
get [>] (LV_SYMBOL_RIGHT). The [?] uses the existing ICON_HELP glyph
baked into icons_24/icons_36 by tools/bake_icons.py.
The helper itself has no callers yet; it's introduced ahead of
Settings → Wallet's rewrite so each subsequent commit that adds a
settings entry can use it from the start.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Polish commits which are not interdependent from #46 and brings them to master. Making remaining #46 commits lighter to review.