Skip to content

[FIX] mac-related changes#160

Merged
isko-odoo merged 3 commits into
betafrom
macos_path_resolver-fix-isko
Jun 12, 2026
Merged

[FIX] mac-related changes#160
isko-odoo merged 3 commits into
betafrom
macos_path_resolver-fix-isko

Conversation

@isko-odoo

@isko-odoo isko-odoo commented Jun 1, 2026

Copy link
Copy Markdown

Description

Briefly describe your changes and the reasoning behind them so that other contributors and reviewers can easily grasp the goal of your PR.

Makes odev compatible with Mac and avoids macOS bloating the repo with temp files

Linked Issues

Link the issues that this PR solves, if any:

  • #[issue number or URL]
  • ...

Compliance

the contribution guide and versioning guide are missing

  • I have read the contribution guide
  • I made sure the documentation is up-to-date both in doctrings and the docs directory
  • I have added or modified unit tests where necessary
  • I have added new libraries to the requirements.txt file, if any
  • I have incremented the version number according the versioning guide
  • The PR contains my changes only and no other external commit

@isko-odoo isko-odoo changed the title mac-related changes [FIX] mac-related changes Jun 1, 2026
@brinkflew

Copy link
Copy Markdown
Contributor

Looking good, can you please target the beta branch instead of main? Thx!

@isko-odoo isko-odoo changed the base branch from main to beta June 1, 2026 15:11
@isko-odoo isko-odoo force-pushed the macos_path_resolver-fix-isko branch from 5471be9 to 9267671 Compare June 1, 2026 15:26
@isko-odoo

Copy link
Copy Markdown
Author

@brinkflew rebased on beta. Didn't tag you myself because the tests didn't run yet, and I have a problem running them on my system, as I can't compare the two, but the failing tests don't really point to my changes. I'll have a deeper look in a bit.

@isko-odoo isko-odoo requested a review from brinkflew June 1, 2026 15:44
@Lok3rs

Lok3rs commented Jun 2, 2026

Copy link
Copy Markdown

I confirm it works, recently ran it on my mac and everything is setup well :)

@brinkflew

Copy link
Copy Markdown
Contributor

@isko-odoo we can enable the tests to run on MacOS in the CI (.github/actions), this might be easier than running locally (I've had issues on linux as well, something isn't totally right in the cleanup I think...).

This may required a bit of work for the setup of the actions. The last time I tried I couldn't properly install postgres but I also couldn't really test it as I have no Mac. If we manage to do that we can enable MacOS in the test matrix.

brinkflew
brinkflew previously approved these changes Jun 4, 2026
@isko-odoo

Copy link
Copy Markdown
Author

@brinkflew The issue I faced is probably related. The code created a db with a random id like test-jtjoae. I tried running the tests but they appeared stuck. Then I tried odev list, and I got an error saying the db test-whatever is corrupted. I did exit with cmd+C, so I can't say it's definitely caused by the code, but I don't think I exited prematurely the first times I tried the tests. And it might be because of the odev.sh changes, but I couldn't run the main/beta branch tests after running them on my own branch..

I'm happy to help you set up the github actions, maybe we can align next week.

@brinkflew

Copy link
Copy Markdown
Contributor

Yeah, same kind of error here, I already noticed that exiting tests with ctrl+c tends to break it more, but I'm not convinced letting it run and exit cleanly is deterministic. That's something to work on. GitHub actions start from scratch everytime so that's less likely to be an issue.

I would love to work on that next week ;)

macOS does not have realpath installed by default. New code checks realpath, and if unavailable, tries readlink
.DS_Store is a macOS specific file that stores metadata and display preferences information
@isko-odoo

Copy link
Copy Markdown
Author

@brinkflew needed to rebase

@isko-odoo isko-odoo merged commit 843dbc1 into beta Jun 12, 2026
6 checks passed
@isko-odoo isko-odoo deleted the macos_path_resolver-fix-isko branch June 12, 2026 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants