[FIX] mac-related changes#160
Conversation
|
Looking good, can you please target the |
5471be9 to
9267671
Compare
|
@brinkflew rebased on beta. Didn't tag you myself because the tests didn't run yet, and I have a problem running them on my system, as I can't compare the two, but the failing tests don't really point to my changes. I'll have a deeper look in a bit. |
|
I confirm it works, recently ran it on my mac and everything is setup well :) |
|
@isko-odoo we can enable the tests to run on MacOS in the CI ( This may required a bit of work for the setup of the actions. The last time I tried I couldn't properly install postgres but I also couldn't really test it as I have no Mac. If we manage to do that we can enable MacOS in the test matrix. |
|
@brinkflew The issue I faced is probably related. The code created a db with a random id like test-jtjoae. I tried running the tests but they appeared stuck. Then I tried odev list, and I got an error saying the db test-whatever is corrupted. I did exit with cmd+C, so I can't say it's definitely caused by the code, but I don't think I exited prematurely the first times I tried the tests. And it might be because of the odev.sh changes, but I couldn't run the main/beta branch tests after running them on my own branch.. I'm happy to help you set up the github actions, maybe we can align next week. |
|
Yeah, same kind of error here, I already noticed that exiting tests with ctrl+c tends to break it more, but I'm not convinced letting it run and exit cleanly is deterministic. That's something to work on. GitHub actions start from scratch everytime so that's less likely to be an issue. I would love to work on that next week ;) |
macOS does not have realpath installed by default. New code checks realpath, and if unavailable, tries readlink
.DS_Store is a macOS specific file that stores metadata and display preferences information
9267671 to
3ad318a
Compare
|
@brinkflew needed to rebase |
Description
Briefly describe your changes and the reasoning behind them so that other contributors and reviewers can easily grasp the goal of your PR.
Makes odev compatible with Mac and avoids macOS bloating the repo with temp files
Linked Issues
Link the issues that this PR solves, if any:
Compliance
the contribution guide and versioning guide are missing
docsdirectoryrequirements.txtfile, if any