Fix dead passphrase validation in Bip38KeyPair encryption constructor#9
Merged
Merged
Conversation
The non-EC-multiply Bip38KeyPair(KeyPair, string) constructor guarded the passphrase with `passphrase == null && passphrase == ""`, which is never true (a string cannot be both null and empty), so the check was dead code. A null passphrase would NRE during key derivation and an empty passphrase would silently encrypt the key with no passphrase. Use `||` so both are rejected. Also corrects the key-null ArgumentException message, which read "Passphrase is required". Ports casascius#15. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The non-EC-multiply Bip38KeyPair(KeyPair, string) constructor guarded the passphrase with
passphrase == null && passphrase == "", which is never true (a string cannot be both null and empty), so the check was dead code. A null passphrase would NRE during key derivation and an empty passphrase would silently encrypt the key with no passphrase. Use||so both are rejected. Also corrects the key-null ArgumentException message, which read "Passphrase is required".Ports casascius#15.