fix(seo): add site name metadata to fix Google showing GitHub#45
Open
akeldamas wants to merge 1 commit into
Open
fix(seo): add site name metadata to fix Google showing GitHub#45akeldamas wants to merge 1 commit into
akeldamas wants to merge 1 commit into
Conversation
PaulBoon
requested changes
Apr 9, 2026
Contributor
PaulBoon
left a comment
PaulBoon
left a comment
There was a problem hiding this comment.
Please update the setup.sh script to pass that ROOT_URL
| if [ $# -ne 2 ]; then | ||
| echo "Usage: $0 <dataverse_container_name> <id>" | ||
| if [ $# -ne 3 ]; then | ||
| echo "Usage: $0 <dataverse_container_name> <id> <root_url>" |
Contributor
There was a problem hiding this comment.
The setup.sh script is not passing the third argument (ROOT_URL)
| # so to undo that escaping, replace all \" with " in the code | ||
| echo "$CODE" | sed 's/\\"/"/g' > "$TMP_DIR"/web-analytics.html | ||
|
|
||
| # append structured data so Google uses the correct site name instead of |
Contributor
There was a problem hiding this comment.
Now it is not only about the web analytics, which might supprise us in the future. But it is the simples solution and documented in the header of the file, so setting up a custom footer for this would be too much of a hassle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
og:site_namemeta tag and JSON-LDWebSiteschema via the web analytics HTML fragmentroot_urlas required 3rd argument toconfigure_web_analytics.shLinked tickets
ODSP-403