fix: preserve async-generated session titles in live status messages#124
Merged
fix: preserve async-generated session titles in live status messages#124
Conversation
This fixes an issue where session titles generated asynchronously (e.g., via SiliconFlow API for Qwen, Kimi, Goose, Codex agents) were not being preserved in live status messages. The issue occurred because applyStateFromEvents() was rebuilding the entire state on each event, but only passing startedAt in baseState, causing the sessionTitle to be lost after the first event was processed. Now we retrieve the existing state from liveParsedState and preserve its sessionTitle when rebuilding the state. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Gnoll
force-pushed
the
fix/qwen-session-title-177172
branch
from
5a0db78 to
1887d55
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
applyStateFromEvents()was rebuilding state on each event but only passingstartedAt, losing the async-generatedsessionTitleafter first eventliveParsedStateand preserve itssessionTitlewhen rebuildingChanges
packages/core/runtime/event-stream.ts:65-74to preservesessionTitlefrom existing stateTest plan
All existing tests pass:
🤖 Generated with Claude Code