Enable passkeys for lszm production - #829
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables passkey (WebAuthn) login for lszm production, matching the
existing lszo production setup.
Two parts are required:
Config flag (this diff): adds
passkeysEnabled: trueto thelszm production environment in
projects/lszm.json. This gates thepasskey UI in the frontend.
GitHub Actions environment variables (already applied to the
lszm_prodenvironment, not part of this diff): the WebAuthn CloudFunctions require RP config at runtime, otherwise they throw.
WEBAUTHN_RPID = lszm.flightbox.aeroWEBAUTHN_ORIGINS = https://lszm.flightbox.aeroWEBAUTHN_RPNAMEis intentionally omitted (defaults toFlightbox,same as lszo).
No new secrets or infra: the webauthn functions already deploy for
lszm_prod(present in the prod matrix) and challenges use theexisting RTDB.
Deploy note: the prod workflow triggers on push to
master, so thismust reach
masterfor passkeys to go live.Caveat: RPID must exactly match the host users load the app from. If
lszm prod is served on a domain other than
lszm.flightbox.aero,registration/auth will fail and both variables need adjusting.