Skip to content

fix: AuxK loss carries no gradient, now backprop combined loss, not reconstruction only #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SohrabTa wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: AuxK loss carries no gradient, now backprop combined loss, not reconstruction only #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crosscode/trainers/topk_crosscoder/trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@ def _calculate_loss_and_log(
**self._get_fvu_dict(batch_BMPD, train_res.recon_acts_BMPD),
}

return reconstruction_loss, log_dict
return loss, log_dict

return reconstruction_loss, None
return loss, None

def aux_loss(
self, batch_BMPD: torch.Tensor, train_res: ModelHookpointAcausalCrosscoder.ForwardResult
Expand Down