chore(seekdb): improve diagnostics for Windows embedded test failures - #41
Open
dengfuping wants to merge 2 commits into
Open
chore(seekdb): improve diagnostics for Windows embedded test failures#41dengfuping wants to merge 2 commits into
dengfuping wants to merge 2 commits into
Conversation
- internal-client-embedded.ts: log SQL + first 8 params on native execute failure when SEEKDB_DEBUG_SQL=1 (or SEEKDB_DEBUG=1) is set, so CI logs reveal the failing statement instead of just "Update execution failed". - test-utils.ts: verify cleanupTestDb actually deleted the directory via fs.access (fs.rm with force:true silently succeeds on Windows file-lock partial failures); warn instead of silently swallowing on final attempt. These are diagnostic-only changes — no behavior change on success path.
…able SEEKDB_DEBUG_SQL - Bump LIBSEEKDB_URL_PREFIX to 252658b8 (oceanbase/seekdb feat/embedded-mode-1.3.0) which surfaces real OB error code/message in execute_update/query paths. - Set SEEKDB_DEBUG_SQL=1 in embedded test job so failing SQL + first 8 params are printed alongside the error, helping diagnose the 14 Windows DML failures on tables with sparse_embedding columns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update execution failed) by surfacing the real OB error/warning + ret code, and verifying cleanupTestDb actually removed the dir.Why
Current Windows CI logs only show generic
Error: Update execution failed. The real OB error code/message is dropped at the C ABI layer. Together with this PR's engine-side change (commit 252658b8 in seekdb), Windows CI will now print real OB error info, plus optional SQL+params preview when SEEKDB_DEBUG_SQL=1.Also: cleanupTestDb on Windows used fs.rm with force:true which silently succeeds even when files are locked. Now it verifies via fs.access and warns.
Test plan
🤖 Generated with Claude Code