test(storage): add OceanBase embedding-failure text fallback coverage… - #1153
Open
kic635 wants to merge 1 commit into
Open
test(storage): add OceanBase embedding-failure text fallback coverage…#1153kic635 wants to merge 1 commit into
kic635 wants to merge 1 commit into
Conversation
…oceanbase#1094) Cover StorageAdapter routing and OceanBaseVectorStore search paths when query embeddings are unavailable, including vector-only backends that must not return false positives. Co-authored-by: Cursor <cursoragent@cursor.com>
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix #1094.
Add required-path unit coverage for OceanBase search when query embeddings are unavailable and the path must fall back to text retrieval (follow-up from PR #1052).
No production code changes.
Solution Description
Add
tests/unit/test_oceanbase_embedding_fallback.pywith two layers of coverage:auto/fts/hybridwithquery_embedding=Noneand a text query are forwarded to an OceanBase-like storevectormode without embedding returns empty and does not call the storehybrid_search=False) return no false-positive resultscandidate_limitcontrols are forwarded correctly_vector_searchsafety belt:vectors=None/[]returns empty and does not callann_searchauto/hybridwithout vectors still run FTS after the empty vector branchVerified locally with: