fix(intelligence): unify rule-based importance scoring - #1142
Conversation
wayyoungboy
left a comment
There was a problem hiding this comment.
Requesting changes because the current rule-based scoring path drops existing metadata/context importance signals.
The new rule-based path delegates to dimension scoring, but that scoring path does not appear to consume the existing metadata.priority, metadata.tags, or context.user_engagement signals. A direct probe on the current head with neutral content plus high-priority/profile/high-engagement metadata/context returns 0.0; the previous rule fallback assigned a positive score from those signals. The new tests patch the dimension scorer, so they do not exercise the real evaluator behavior.
Please carry the metadata/context boosts into the real dimension scoring path, or keep the old signal path covered by a test that calls the real evaluator instead of patching it.
|
@wayyoungboy Thanks for the review! Fixed in 0d0da9a. The rule-based path now carries the existing metadata/context signals into the real dimension scoring path:
Verified:
|
|
Thanks for the follow-up. This is still not ready to merge while the previous Please request re-review after confirming that the rule-based path carries the existing metadata/context importance signals into the six-dimension scoring path, with regression coverage for those signals. Once that review is cleared, this can be reconsidered for merge. |
Summary
weighted_totalto importance breakdown and shares weighted aggregation with LLM criteria synthesis.Test plan
python -m pytest tests/unit/intelligence/test_importance_evaluator.pypython -m pytest tests/unit/intelligencegit diff --check