occurrences: fix a bug with out-of-sync file detection when src files don't change sizes - #2115
Open
ikostia wants to merge 1 commit into
Open
occurrences: fix a bug with out-of-sync file detection when src files don't change sizes#2115ikostia wants to merge 1 commit into
ikostia wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prior to this change,
find_linked_uidsdid not report out-of-sync files (unlikeget_external_locs), despite observing them (log ~title "Found clashing idents %S <> %S. Ignoring UID %a."). This PR exposes this notion of a name clash (which may happen when a rename has just happened, but the file hasn't been rebuilt yet) in the return type offind_linked_uids: now the fn returns both the related UIDs and the files with clashes. The consumer fnlocs_ofjust joinsclashing_fileswith the out-of-sync files returned byget_external_locs.Testing
r-stale-after-rename.tdemonstrates how incompleteness-related log messages show up when something has been renamed by not rebuilt.