Fix for Type-enclosing resolves * in tuple types as integer multiplication - #2105
Open
PizieDust wants to merge 3 commits into
Open
Fix for Type-enclosing resolves * in tuple types as integer multiplication #2105PizieDust wants to merge 3 commits into
PizieDust wants to merge 3 commits into
Conversation
voodoos
reviewed
Jul 21, 2026
| "class": "return", | ||
| "value": "Integer multiplication. | ||
| Left-associative operator, see {!Ocaml_operators} for more information.", | ||
| "value": "Not in environment '*'", |
Collaborator
There was a problem hiding this comment.
This is still not ideal. I will think about it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #2093.
Here we remove values from the fallback list when Merlin is looking up a type and added a check so merlin doesn't guess that a text may be a math expression when analyzing a type.
cc @voodoos