lexer: skip string literals except in interpolation - #2098
Open
ikostia wants to merge 8 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
See commit da0ab7d with a test demonstrating the bug this PR fixes, but TL/DR is that
single documenton the position of a/in a string literal"/usr/bin/home"would return the division opeartor docs. This is not desired, of course.It is important to note that deciding that's a correct fix here is tricky:
%{name}in"hello %{name}"is just a bit of a string literal, as per the compiler%{name}as an interpolation for the purposes of documentation/hover etcI chose to prioritize 2, so this PR handles interpolation inside string literals and skips only non-interpolated bits of string literals.
Testing
Existing tests pass + failure demonstration test now tests the correct behavior