Fix fuzzy CI - #2086
Conversation
|
Thanks for the review |
|
Why does it fail now? 🤔 The ppxlib version 0.38 seems to support OCaml 5.5 and the ppxlib version has been fixed accordingly in the lock file. |
Because that's what CIs are for 😂 |
Can you add prints right before building irmin to check the ppxlib version ? |
02f300f to
8fca4aa
Compare
| if: steps.irmin-cache.outputs.cache-hit != 'true' | ||
| run: | | ||
| cp .github/fuzzy-ci-helpers/irmin.3.10.0.opam.locked irmin/irmin.opam.locked | ||
| cp .github/fuzzy-ci-helpers/irmin.$IRMIN_VERSION.opam.locked irmin/irmin.opam.locked |
There was a problem hiding this comment.
I suspect the variable expansion doesn't work here, you might need quotes ".github/fuzzy-ci-helpers/irmin.$IRMIN_VERSION.opam.locked"
There was a problem hiding this comment.
I've quoted all the IRMIN_VERSION variable expansion and it has no effect
|
Maybe the Opam monorepo has not been upgraded to OCaml 5.5? |
Didn't you say it used to work on your machine / fork ? |
|
My new print shows the the irmin.opam.locked file we get is not the one we expect. |
|
Ah I think I get it ! We checkout the main branch before copying the lock file 😅 |
|
🙌 |
|
Nice, good catch! |

$ opam switch create ocaml-base-compiler.5.5.0 $ opam switch ocaml-base-compiler.5.5.0 $ git clone https://github.com/mirage/irmin $ git checkout 7fa4b043a97944635cc100ae2e7dd85f73d8a4ce # The release commit hash of the release of Irmin version 3.10 $ opam install opam-monorepo $ opam repository add dune-universe git+https://github.com/dune-universe/opam-overlays.git $ opam-monorepo lock irmin irmin-pack irmin-tezos --ocaml-version=5.5.0Merging this PR should close that issue #2006