Skip to content

Fix fuzzy CI - #2086

Open
Tim-ats-d wants to merge 6 commits into
ocaml:mainfrom
Tim-ats-d:fix-ci
Open

Fix fuzzy CI#2086
Tim-ats-d wants to merge 6 commits into
ocaml:mainfrom
Tim-ats-d:fix-ci

Conversation

@Tim-ats-d

@Tim-ats-d Tim-ats-d commented Jul 6, 2026

Copy link
Copy Markdown
Contributor
  • Update from OCaml 5.3 to 5.5
  • Update Merl-an CLI usage
  • Regenerate Irmin lock file using this method:
$ opam switch create ocaml-base-compiler.5.5.0
$ opam switch ocaml-base-compiler.5.5.0
$ git clone https://github.com/mirage/irmin
$ git checkout 7fa4b043a97944635cc100ae2e7dd85f73d8a4ce # The release commit hash of the release of Irmin version 3.10
$ opam install opam-monorepo
$ opam repository add dune-universe git+https://github.com/dune-universe/opam-overlays.git
$ opam-monorepo lock irmin irmin-pack irmin-tezos --ocaml-version=5.5.0 

Merging this PR should close that issue #2006

@Tim-ats-d Tim-ats-d closed this Jul 6, 2026
@Tim-ats-d Tim-ats-d reopened this Jul 6, 2026
@voodoos voodoos added the no changelog Turn off CI changelog-check label Jul 6, 2026
Comment thread .github/workflows/fuzzy-ci.yml
@Tim-ats-d

Copy link
Copy Markdown
Contributor Author

Thanks for the review

@Tim-ats-d

Tim-ats-d commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

Why does it fail now? 🤔 The ppxlib version 0.38 seems to support OCaml 5.5 and the ppxlib version has been fixed accordingly in the lock file.

@voodoos

voodoos commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Why does it fail now? 🤔

Because that's what CIs are for 😂

@voodoos

voodoos commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

Why does it fail now? 🤔 The ppxlib version 0.38 seems to support OCaml 5.5 and the ppxlib version has been fixed accordingly in the lock file.

Can you add prints right before building irmin to check the ppxlib version ?

@Tim-ats-d
Tim-ats-d force-pushed the fix-ci branch 6 times, most recently from 02f300f to 8fca4aa Compare July 9, 2026 14:41
@voodoos

voodoos commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator
image

🤷‍♂️

Comment thread .github/workflows/fuzzy-ci.yml Outdated
if: steps.irmin-cache.outputs.cache-hit != 'true'
run: |
cp .github/fuzzy-ci-helpers/irmin.3.10.0.opam.locked irmin/irmin.opam.locked
cp .github/fuzzy-ci-helpers/irmin.$IRMIN_VERSION.opam.locked irmin/irmin.opam.locked

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect the variable expansion doesn't work here, you might need quotes ".github/fuzzy-ci-helpers/irmin.$IRMIN_VERSION.opam.locked"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've quoted all the IRMIN_VERSION variable expansion and it has no effect

@Tim-ats-d

Copy link
Copy Markdown
Contributor Author

Maybe the Opam monorepo has not been upgraded to OCaml 5.5?

@voodoos

voodoos commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Maybe the Opam monorepo has not been upgraded to OCaml 5.5?

Didn't you say it used to work on your machine / fork ?

@voodoos

voodoos commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

My new print shows the the irmin.opam.locked file we get is not the one we expect.

@voodoos

voodoos commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Ah I think I get it ! We checkout the main branch before copying the lock file 😅
I am going to push the lockfile first

@voodoos

voodoos commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

🙌

@Tim-ats-d

Copy link
Copy Markdown
Contributor Author

Nice, good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog Turn off CI changelog-check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants