refactor: move build polling loop to dune_engine#14618
Merged
Merged
Conversation
rgrinberg
force-pushed
the
push-upslwuspyzyz
branch
4 times, most recently
from
5657d18 to
910503e
Compare
Move the watch-mode build loop from Scheduler.Run into a new Dune_engine.Build_loop module. Keep scheduler-owned state behind a narrow Scheduler.Build_loop adapter so the change remains mechanical and preserves existing behavior. Update build, exec, and scheduler tests to call the new build-loop API. Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
rgrinberg
force-pushed
the
push-upslwuspyzyz
branch
from
910503e to
df8cde0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the watch-mode build loop from Scheduler.Run into a new Dune_engine.Build_loop module. Keep scheduler-owned state behind a narrow Scheduler.Build_loop adapter so the change remains mechanical and preserves existing behavior.
Update build, exec, and scheduler tests to call the new build-loop API.