test: singleton (wrapped false) lib with requires#14582
Open
robinbb wants to merge 1 commit into
Open
Conversation
robinbb
force-pushed
the
robinbb-test-singleton-with-requires
branch
from
fc7f76f to
93004c2
Compare
Regression guard for the build of a multi-module consumer of a `(wrapped false)` singleton library that itself has `(libraries leaf)`. The consumer never names the leaf's module directly; coverage that this transitive dependency shape continues to work. Sister fixture to `no-ocamldep-leaf-lib.t` (the singleton-with-no-requires case). Signed-off-by: Robin Bate Boerop <me@robinbb.com>
robinbb
force-pushed
the
robinbb-test-singleton-with-requires
branch
from
93004c2 to
8c921c2
Compare
There was a problem hiding this comment.
Pull request overview
Adds a new cram regression test that ensures a multi-module consumer can build against a (wrapped false) singleton library (bridge) that itself depends on another leaf library (leaf), without the consumer naming the leaf's modules directly.
Changes:
- New cram test
singleton-with-requires.texercising a transitiveconsumer → bridge → leafbuild with(wrapped false)libraries.
Collaborator
Author
|
@Alizter This came from my 9-layer stack for 14492. I factored it out to make the stack smaller. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression guard for the build of a multi-module consumer of a
(wrapped false)singleton library that itself has(libraries leaf). The consumer never names the leaf's module directly; coverage that this transitive shape continues to work.Sister fixture to
no-ocamldep-leaf-lib.t(the singleton-with-no-requires case).