refactor: typed Filename.t#14545
Merged
Merged
Conversation
rgrinberg
force-pushed
the
push-vsrwkrxpltro
branch
12 times, most recently
from
7d7bcf5 to
45245e4
Compare
Filename.t now only represnets valid base names Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
rgrinberg
force-pushed
the
push-vsrwkrxpltro
branch
from
45245e4 to
631a955
Compare
Member
Author
|
There are still some functions that need improvement, but this is still better than the status quo. Keeping this PR up to date is painful as well of course. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This typed
Filename.tdoes not allow any directory separators or invalid file names.