WIP temporarily add policySwitchoverTime - #9
Conversation
| summary <- summarizeTransfer t.sender csum.openRoundNumber csum.amuletPrice csum.config isum osum | ||
|
|
||
| case isum.mintedSvRewardMap of | ||
| currentRound <- getIssuingMiningRound csum csum.openRoundNumber |
There was a problem hiding this comment.
This won't work. A round is never both in the open and issuing state.
I suggest to push the evaluation of activation time to the SvRewardCoupon minting, and only populate mintedSvRewardMap when minting receipts need to be created.
There was a problem hiding this comment.
@meiersi-da I guess what we're trying to do here is get a transaction time to compare against the policySwitchoverTime, any idea where we could get the time of when the transfer is effective?
There was a problem hiding this comment.
answered in the call. I'd suggest to use the opensAt of the IssuingMiningRound that is used to collect the SvRewardCoupon.
| amuletPrice = externalPartyConfigState.amuletPrice | ||
| rewardCalculationVersion = externalPartyConfigState.rewardCalculationVersion | ||
| eventLogCid = Some (toInterfaceContractId context.externalPartyConfigState) | ||
| , externalPartyConfigState.policySwitchoverTimes |
There was a problem hiding this comment.
push this as a field into TransferContextSummaryV2 so its available everywhere.
|
|
||
| transferPreapprovalBaseDuration = None | ||
|
|
||
| policySwitchoverTimes = Some TextMap.empty |
There was a problem hiding this comment.
| policySwitchoverTimes = Some TextMap.empty | |
| defaultPolicySwitchoverTimes = Some TextMap.empty |
There was a problem hiding this comment.
@meiersi-da This function seems to return an AmuletConfig, are you saying we should change the field name in general?
2 participants
Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./upgrade_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./lsu_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines