WIP: Minimum Lock Amounts - #15
Draft
jonored wants to merge 2 commits into
Draft
Conversation
Signed-off-by: Jonathan Gibbons <jonathan.gibbons@obsidian.systems>
Signed-off-by: Jonathan D.K. Gibbons <jonathan.gibbons@obsidian.systems>
meiersi-da
reviewed
Aug 25, 2026
meiersi-da
left a comment
meiersi-da
left a comment
There was a problem hiding this comment.
Thx. Looks like a simple addition. I'll review fully once it's out of WIP.
| rewardConfig : Optional RewardConfig | ||
| -- ^ Configuration for the reward accounting and calculation. If None, then on-ledger reward tracking is used. | ||
| transferPreapprovalBaseDuration : Optional RelTime -- ^ Base duration of a transfer pre-approval granted for free on creation and renewal. Default: 90 days. | ||
| minimumGovernanceLock : Optional Decimal -- ^ The minimum amount to enforce for a governance lock. Default: 10k Amulet. |
There was a problem hiding this comment.
Suggested change
| minimumGovernanceLock : Optional Decimal -- ^ The minimum amount to enforce for a governance lock. Default: 10k Amulet. | |
| minimumGovernanceLockAmount : Optional Decimal -- ^ The minimum amount to enforce for a governance lock. Default: 10k Amulet. |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./upgrade_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./lsu_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines