fix(blink): don't check blink.cmp markdown config isn't a list#793
Merged
Conversation
blink.cmp supports an inherits_default key in its per_filetype sources
Member
|
the change makes sense, but the util file change is not what the comment meant, it was that after 0.12 we will have minimum 0.11 so that a util/compat stuff are all not required #778 but this will be merged down the line, so remove the thing and I'll merge |
This reverts commit b564654.
Member
|
thank you for the fix! @all-contributors add @antinomie8 for code |
Contributor
|
I've put up a pull request to add @antinomie8! 🎉 |
neo451
added a commit
that referenced
this pull request
Apr 18, 2026
* fix(blink): don't check blink.cmp markdown config isn't a list blink.cmp supports an inherits_default key in its per_filetype sources * feat(util): use vim.islist for neovim >=0.12 * docs: update changelog * Revert "feat(util): use vim.islist for neovim >=0.12" This reverts commit b564654. --------- Co-authored-by: neo451 <111681693+neo451@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
blink.cmp source injection
blink.cmp supports an inherits_default key in its per_filetype sources, which fails the
util.islistcheck for adding the plugin's completion source, so I removed it. Additionally I updatedutil.islistso it usesvim.islistin neovim >= 0.12 as the comments said to do.PR Checklist
CHANGELOG.mdis updatedREADME.mdfilemake chores(for style, lint, types, and tests)