tls: Add client CA configuration for mTLS verification - #927
Closed
saswatamcode wants to merge 1 commit into
Closed
saswatamcode wants to merge 1 commit into
saswatamcode wants to merge 1 commit into
Conversation
Add --tls.client-ca-file flag and configure tls.Config.ClientCAs to enable proper verification of client certificates. Without this, the gateway cannot verify client certs against a specific CA. Note, this is for mTLS between sender and Observatorium API Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
Member
Author
|
@philipgough pointed out that each tenant passes it through already https://github.com/observatorium/api/blob/main/main.go#L259-L261 via their own config, so this is probably not required in such a setup |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add --tls.client-ca-file flag and configure tls.Config.ClientCAs to enable proper verification of client certificates. Without this, the gateway cannot verify client certs against a specific CA.
Note, this is for mTLS between sender and Observatorium API