Skip to content

design-audit: use body2 typography token for LocationPicker search options #1027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
frewsxcv wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

design-audit: use body2 typography token for LocationPicker search options #1027

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/src/components/map/LocationPicker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@
if (!mapContainer.current || map.current) return;

const safeLat = latitude && Number.isFinite(latitude) ? latitude : 0;
const safeLng = longitude && Number.isFinite(longitude) ? longitude : 0;

Check warning on line 199 in frontend/src/components/map/LocationPicker.tsx

View workflow job for this annotation

GitHub Actions / frontend-lint

react-hooks(exhaustive-deps) 

frontend/src/components/map/LocationPicker.tsx:199:21: React Hook useEffect has missing dependencies: 'longitude', 'uncertaintyMeters', 'updateMarker', 'latitude', 'onChange', and 'markerColor'

const { map: mapInstance, geolocateControl } = createMap(
mapContainer.current,
Expand Down Expand Up @@ -392,7 +392,7 @@
renderOption={(props, option) => {
const { key, ...otherProps } = props;
return (
<Box component="li" key={key} {...otherProps} sx={{ fontSize: "0.875rem" }}>
<Box component="li" key={key} {...otherProps} sx={{ typography: "body2" }}>
{option.display_name}
</Box>
);
Expand Down
Loading