Skip to content

design-audit: share heroIconSx for the 48px prompt icons in LiveIdView and PhoneStart #1017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frewsxcv merged 1 commit into from
Nov 6, 2026
Merged

design-audit: share heroIconSx for the 48px prompt icons in LiveIdView and PhoneStart #1017

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion frontend/src/components/batch/phone/PhoneStart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// Phone layout, before any photos: what the tool does and the way in.
import { Alert, AlertTitle, Box, Button, CircularProgress, Typography } from "@mui/material";
import PhotoLibraryIcon from "@mui/icons-material/PhotoLibrary";
import { heroIconSx } from "../../common/layoutSx";
import { MAX_BATCH_PHOTOS } from "../../../lib/batchUpload";
import { formatMegabytes } from "../../../lib/imageSelection";
import { useMaxPhotoSize } from "../../../lib/query/hooks";
Expand Down Expand Up @@ -46,7 +47,7 @@ export function PhoneStart({ onChoosePhotos, converting, stripsLocation }: Phone
textAlign: "center",
}}
>
<PhotoLibraryIcon color="primary" sx={{ fontSize: 48 }} />
<PhotoLibraryIcon color="primary" sx={heroIconSx} />
<Button
variant="contained"
size="large"
Expand Down
3 changes: 3 additions & 0 deletions frontend/src/components/common/layoutSx.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ export const detailHeaderSx = {
/** Inline glyph size for icons embedded in chips, small buttons and caption rows. */
export const miniIconSx = { fontSize: 14 } as const;

/** Large glyph for full-panel prompts (location permission, empty photo picker). */
export const heroIconSx = { fontSize: 48 } as const;

/** Glyph size for icons in caption/status rows (batch card status lines). */
export const captionIconSx = { fontSize: 16 } as const;

Expand Down
4 changes: 2 additions & 2 deletions frontend/src/components/identification/LiveIdView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import { useAppDispatch } from "../../store";
import { openUploadModal, setPendingUploadFiles, addToast } from "../../store/uiSlice";
import { InRangeIndicator } from "../common/InRangeIndicator";
import { CloseIconButton } from "../common/CloseIconButton";
import { cornerPinSx } from "../common/layoutSx";
import { cornerPinSx, heroIconSx } from "../common/layoutSx";

/**
* Full-screen live camera identifier — point the camera at something and the
Expand Down Expand Up @@ -182,7 +182,7 @@ export function LiveIdView() {
onClick={handleClose}
sx={[cornerPinSx("top-left"), { color: "common.white" }]}
/>
<PlaceIcon sx={{ fontSize: 48, opacity: 0.85 }} />
<PlaceIcon sx={{ ...heroIconSx, opacity: 0.85 }} />
{locationState === "prompting" ? (
<>
<Typography variant="h6">Allow location access</Typography>
Expand Down
Loading