Conversation
grahamschock
left a comment
grahamschock
left a comment
There was a problem hiding this comment.
Added some comments. We can discuss via comments or elsewhere.
| @@ -0,0 +1,21 @@ | |||
| Section,Start Time,End Time,Time Elapsed | |||
| Create Tasks,0.01173190000008617,0.011608300001171301,-0.0001235999989148695 | |||
There was a problem hiding this comment.
Section is just a label for us to determine what section of code we were timing
| taskData = [[],[],[],[],[]] | ||
|
|
||
| #initialize function to start our graph | ||
| def __init__(self): |
There was a problem hiding this comment.
Where is this code actually being ran? In server.py? Do we need a constructor there and need to be calling things like addPoint in certain places?
There was a problem hiding this comment.
During testing I was running this in server.py, but I was unsure where we wanted to pull in these values. We would need to create the constructor there and call these functions -- I took it out after doing time testing but we would just place it in where appropriate.
| plt.xlabel('Tasks per Request') | ||
| plt.ylabel('Average Reward') | ||
| plt.title(self.title) | ||
| plt.savefig('benchData/taskVreward.png') |
There was a problem hiding this comment.
Do we have any idea what this png looks like currently? Can you add that to the PR? @kylevitale2
There was a problem hiding this comment.
I haven't tested this yet, I was unsure of where to pull the rewards from, and during the times I ran server.py and client.py it seemed I only got one run, which can be graphed but defeats the average aspect. I'll do tests on this soon.
| Create Tasks,0.006634500001382548,0.00645040000017616,-0.0001841000012063887 | ||
| Create Tasks,0.006856500000139931,0.006442500000048312,-0.00041400000009161886 | ||
| Create Tasks,0.00744479999957548,0.00603179999961867,-0.00141299999995681 | ||
| Create Tasks,0.006359799999700044,0.006122100001448416,-0.00023769999825162813 |
There was a problem hiding this comment.
Why do we have negative time? Is this a bug or is there something else wrong? What tasks did we get these data points from?
There was a problem hiding this comment.
I'm unsure on the negative times -- it could be something with the API that was wrong, or it could be from creating the start time at one point and then repeatedly trying to clock out. I'll do more testing, and on sections that don't get repeated. I'll also look into some different APIs to track time.
2 participants
Created classes for graphs and time tracking, imported said classes into server.py