fix: include mcp/package.json in npm files array#36
Open
danshapiro wants to merge 1 commit into
Open
Conversation
The compiled mcp/dist/index.js references ../package.json at runtime to read SERVER_VERSION. Since mcp/package.json was not listed in the root files array, npm installs excluded it, causing: Error: Cannot find module '.../mcp/package.json' This made the package un-runnable when installed via npx or npm install.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compiled
mcp/dist/index.jsreferences../package.jsonat runtime to readSERVER_VERSION. Sincemcp/package.jsonwas not listed in the rootfilesarray, npm installs excluded it, causing:This made the package un-runnable when installed via
npx -y github:obra/superpowers-chromeornpm install superpowers-chrome-mcp.Adding
mcp/package.jsonto the files array fixes the crash on startup.