Repository navigation
fix: avoid duplicate inline OpenAPI model names - #62
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ledger v0.20.2 defines inline
Paramsobjects in bothApiErrorResponseandIntegrationConflictResponse. Without path prefixes, openapi-python-client reports duplicate models and drops the conflict schema and the start/finish run 409 responses, causing the update workflow to fail.Enable path prefixes for inline model names and add a regression test that generates the client with
--fail-on-warning, round-trips both error models, and verifies typed 409 parsing for both run endpoints. Keep generated sources and the checked-in contract unchanged; the update workflow will regenerate them after this fix is merged.Validation: 64 tests passed; Ruff check/format, strict documentation build, and compileall passed. The regression test fails with the original configuration. The full Ledger v0.20.2 contract generates without warnings with workflow-pinned openapi-python-client 0.29.0 and locked development version 0.29.1.
After merging, manually run Update client from Oblidog Ledger with
release_tag=v0.20.2to use the updated configuration (re-running the old run would use its original commit).