feat(#571): add zizmor static analysis workflow#968
Draft
kreinba wants to merge 2 commits into
Draft
Conversation
github-actions
Bot
added
the
core
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #571 asks for zizmor in the build pipeline. The tool is a static analyzer for GitHub Actions workflows, catching things like unpinned actions, excessive permissions and template-injection risks before they reach master.
This change adds a single workflow at
.github/workflows/zizmor.yml. It runs on push to master and on every pull request to master, matching the trigger shape used byactionlint.yml,qulice.yml,mvn.ymland the rest. The job useszizmorcore/zizmor-action@v0.5.6in its default mode, which is the recommended one for public repositories: findings land on the Security tab via code scanning rather than failing the build outright, so existing workflows are not blocked while their issues are triaged. Permissions on the job are scoped explicitly tosecurity-events: write,contents: read, andactions: read, with the top-levelpermissionsblock set tocontents: read.I did not run a local Maven build for this change, since the only file touched is a GitHub Actions YAML; the workflow itself will be exercised by Actions on this pull request, which is the relevant signal here. No source, tests, or
pom.xmlwere modified.Closes #571