#869: exclude jcabi-log from jcabi-xml#904
Conversation
GHX5T-SOL
left a comment
There was a problem hiding this comment.
Checked head 349db3820839aed6e40a12c2162d5ed5f3d7aa53.
The patch is limited to pom.xml and only excludes transitive com.jcabi:jcabi-log from jcabi-xml. Since jcabi-log:0.24.3 remains declared directly by the project, the runtime classpath keeps jcabi-log while removing the extra jcabi-xml -> jcabi-log dependency edge that was causing the SPDX relationship problem described in #869.
Validation I ran:
git diff --check origin/master...HEAD- diff-only
gitleaks stdin --no-banner --redact --exit-code 1 mvn --errors --batch-mode -DskipTests dependency:tree '-Dincludes=com.jcabi'confirmedjcabi-xml,jcabi-log,jcabi-manifests, and test-onlyjcabi-matchersas separate project dependencies, with no nestedjcabi-xml -> jcabi-logedge in the filtered treeJAVA_HOME=/opt/homebrew/Cellar/openjdk/25.0.2/libexec/openjdk.jdk/Contents/Home mvn --errors --batch-mode -q -DskipITs packagecompleted successfully locally
Hosted check readback is also clean for the relevant jobs: actionlint, bashate, copyrights, deep, labeler, markdown-lint, mvn (ubuntu-24.04, 23), mvn (macos-15, 23), mvn (windows-2022, 23), pdd, qulice, reserved, reuse, shellcheck, typos, vale, xcop, and yamllint are successful. ort, hone, and jmh are skipped by the workflow gating, so I did not treat them as validation evidence.
|
@GHX5T-SOL Thanks for the review! You've earned +4 points following our bonus policy: started with +12 base points, then -8 for no comments (as per policy for zero feedback), -4 for having only 6 hits-of-code (below the 32 minimum), but we added +4 to ensure you meet the minimum reward threshold. Your running score is +31 - don't forget to check your Zerocracy account too! 🚀 |
|
Merged current Resolution:
Validation:
Limitation: I could not run local Maven because this shell has no |
Closes #869.
This excludes
com.jcabi:jcabi-logfrom the directjcabi-xmldependency. The project already declaresjcabi-log:0.24.3directly, so the classpath keepsjcabi-log, while ORT no longer receives the extrajcabi-xml -> jcabi-logdependency relationship that the SPDX reporter cannot map.Validation:
mvn -version-> Apache Maven 3.9.16, Java 21.0.11.mvn -DskipTests dependency:tree '-Dincludes=com.jcabi'->jcabi-xmlandjcabi-logare separate direct compile dependencies.mvn -q -DskipITs package.mvn clean verify -PskipTests -Pqulice --errors --batch-mode.git diff --check.git diff -- pom.xml | gitleaks stdin --no-banner --redact --exit-code 1 --> no leaks found.Limitation: I did not run ORT locally. The repository
ortworkflow is currently gated byvars.RUN_WORKFLOW == 'true', and the latest publicortruns are skipped.