fix(#960): drop unused postinstall and patch-package#990
Open
Thayorns wants to merge 2 commits into
Open
Conversation
added 2 commits
June 9, 2026 23:37
Contributor
Author
|
@yegor256 take a look please |
Contributor
Author
|
@yegor256 review please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
postinstallscript and thepatch-packagedevDependency were left over from when the project appliedpatches/grunt-mocha-cli+7.0.0.patch. That patch setspawnOptions.opts.shell = true(and appended a.cmdsuffix) on Windows becausegrunt-mocha-clispawned mocha as a separate child process, which needed a shell on Windows.The project now runs tests through
grunt-mocha-test, which loads and runs mocha in-process (new Mocha(...)thenmocha.run()intasks/lib/MochaWrapper.js). There is nochild_process, nospawn, and no shell involved, so the Windows-shell fix has nothing to apply to and is not needed.Since no patch is required, this removes the now-empty
scripts/postinstall.js, itspostinstallentry inpackage.json, and the unusedpatch-packagedevDependency (with the correspondingpackage-lock.jsoncleanup).Closes #960.