Skip to content

fix(#960): drop unused postinstall and patch-package#990

Open
Thayorns wants to merge 2 commits into
objectionary:masterfrom
Thayorns:960
Open

fix(#960): drop unused postinstall and patch-package#990
Thayorns wants to merge 2 commits into
objectionary:masterfrom
Thayorns:960

Conversation

@Thayorns

@Thayorns Thayorns commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

The postinstall script and the patch-package devDependency were left over from when the project applied patches/grunt-mocha-cli+7.0.0.patch. That patch set spawnOptions.opts.shell = true (and appended a .cmd suffix) on Windows because grunt-mocha-cli spawned mocha as a separate child process, which needed a shell on Windows.

The project now runs tests through grunt-mocha-test, which loads and runs mocha in-process (new Mocha(...) then mocha.run() in tasks/lib/MochaWrapper.js). There is no child_process, no spawn, and no shell involved, so the Windows-shell fix has nothing to apply to and is not needed.

Since no patch is required, this removes the now-empty scripts/postinstall.js, its postinstall entry in package.json, and the unused patch-package devDependency (with the corresponding package-lock.json cleanup).

Closes #960.

@Thayorns

Copy link
Copy Markdown
Contributor Author

@yegor256 take a look please

@Thayorns

Copy link
Copy Markdown
Contributor Author

@yegor256 review please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Investigation needed in postinstall.js functionality

1 participant