test: cover parser version request behavior#980
Open
999axel999 wants to merge 1 commit into
Open
Conversation
Thayorns
reviewed
Jun 21, 2026
Thayorns
left a comment
Thayorns
left a comment
Contributor
There was a problem hiding this comment.
A test should inject the request collaborator through a constructor, not by hijacking require.
Also, this PR is a duplicate, the issue is closed already
| * @param {Function} check Test callback | ||
| * @return {*} Callback result | ||
| */ | ||
| const withRequestStub = (request, check) => { |
Contributor
There was a problem hiding this comment.
I would recommend to rename this function to be less composite
| * Load parser-version with a temporary sync-request implementation. | ||
| * @param {Function} request Request stub | ||
| * @param {Function} check Test callback | ||
| * @return {*} Callback result |
Contributor
There was a problem hiding this comment.
The doc says @return {*} — returning an arbitrary passthrough invites null propagation
| const withRequestStub = (request, check) => { | ||
| const parserPath = require.resolve(parserModule), | ||
| requestPath = require.resolve(requestModule), | ||
| originalParser = require.cache[parserPath], |
Contributor
There was a problem hiding this comment.
require.cache — this is shared global state and reflection-like introspection of the module system (require.resolve, cache surgery). Type/internals introspection is prohibited
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
exists()returnsfalsefrom its catch branch.Closes #971
Tests
node ..\objectionary__eoc_fix\node_modules\mocha\bin\mocha.js test\test_parser_version.js --grep 'constructs correct Maven Central URL|handles network errors gracefully' --timeout 1200000-> 2 passingnode ..\objectionary__eoc_fix\node_modules\eslint\bin\eslint.js test\test_parser_version.js-> passedgit diff --check-> passedgit merge-tree --write-tree origin/master HEAD-> passed