test: check parser validation output#979
Open
999axel999 wants to merge 1 commit into
Open
Conversation
Thayorns
reviewed
Jun 21, 2026
Comment on lines
+84
to
+92
| assert(error, 'Command should fail with invalid version'); | ||
| assert( | ||
| error.stderr.toString().includes( | ||
| 'Parser version 999.999.999 is not available in Maven Central.' | ||
| ), | ||
| error.stderr.toString() | ||
| ); | ||
| assert.strictEqual( | ||
| fs.existsSync(path.resolve(home, 'target')), |
Contributor
There was a problem hiding this comment.
Here it checks:
(a) an error was thrown,
(b) the stderr message content,
(c) the target dir absence
— three behaviors in one test. The early-validation behavior it claims to test is really (c); (a) and (b) are separate concerns already covered by the rejects invalid parser version test.
| } | ||
| assert(error, 'Command should fail with invalid version'); | ||
| assert( | ||
| error.stderr.toString().includes( |
Contributor
There was a problem hiding this comment.
It asserts on an error message — explicitly forbidden.
Contributor
|
Also, unfortunately the issue is already closed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #972
Tests
nodebootstrap + Mocha:test/commands/test_parse.js --grep 'validates parser version'-> 1 passingnode ..\objectionary__eoc_fix\node_modules\eslint\bin\eslint.js test\commands\test_parse.jswith sharedNODE_PATH-> passedgit diff --check-> passedgit merge-tree --write-tree origin/master HEAD-> passed