fix: declare test helper variables#977
Open
999axel999 wants to merge 1 commit into
Open
Conversation
Thayorns
reviewed
Jun 21, 2026
| it('fills output depending on the number of placeholders in the input code', (done) => { | ||
| const home = makeHome(); | ||
| for (numberOfPlaceholders = 0; numberOfPlaceholders < 3; ++numberOfPlaceholders) { | ||
| for (let numberOfPlaceholders = 0; numberOfPlaceholders < 3; ++numberOfPlaceholders) { |
Contributor
There was a problem hiding this comment.
i would rather rename this variable to be less composite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
callsandoptsinsidetest/commands/java/test_pipeline.jstests instead of leaking globals.numberOfPlaceholdersinside thegenerate_commentsloops.globalThis.Closes #969
Tests
node ..\objectionary__eoc_fix\node_modules\mocha\bin\mocha.js test\commands\java\test_pipeline.js --timeout 1200000node ..\objectionary__eoc_fix\node_modules\mocha\bin\mocha.js test\commands\test_generate_comments.js --grep "does not leak placeholder" --timeout 1200000node ..\objectionary__eoc_fix\node_modules\eslint\bin\eslint.js test\commands\java\test_pipeline.js test\commands\test_generate_comments.jsgit diff --check origin/master...HEADNote: full
test/commands/test_generate_comments.jsis not runnable in this local Windows shell because its helper spawns barenodeviaexecSync, and that child command is not found in this environment. The new leak regression itself was run and passes.Prepared with local automation assistance and reviewed before submission.