#257: replace sync-request with curl#950
Conversation
|
@nacNAC333 Thanks for your contribution, we appreciate it! Before we can merge this pull request, we need to see all CI workflows pass without errors. We can't merge the pull request into the master branch unless all workflows are green. Try to fix them, also paying attention to code style issues. |
|
Thanks for working on this. I noticed a few blockers worth fixing before merge:
Also, issue #257 explicitly asks for a Maven-native implementation via |
|
@nacNAC333 merge conflict here |
|
Rebased on master and squashed to one commit. All three review points addressed:
|
Fixes #257
Replaces the
sync-requestnpm package withcurlviachild_process.execSyncfor fetching Maven Central metadata.sync-requestpulls in a large transitive dependency tree and has known issues with newer Node versions.curlis universally available on all supported platforms (macOS, Linux, Windows via PowerShell).Changes:
parser-version.jsto useexecSync("curl ...")instead ofsync-requestsync-requestfrompackage.jsondependenciesexists()method for version validation using HTTP HEAD check