Swift 4 refactoring - syntactical changes and new JSONDecoder()#9
Open
jrathert wants to merge 2 commits into
Open
Swift 4 refactoring - syntactical changes and new JSONDecoder()#9jrathert wants to merge 2 commits into
jrathert wants to merge 2 commits into
Conversation
Mainly some type conversions (get rid of NS*), rename of functions, syntactical sugar etc.
This simplifies the code a lot, as the parse closure is in Resources is (almost) independent of the actual type, and we do not need any specific initialisers any more. Only requirement is to make use of the new Decodable protocol for all structures used in JSON API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There seem to be some pull requests for Swift 4 compatibility - this one also simplifies the code by making use of JSONDecoder().