Repository navigation
build: adopt the Vite+ contract with type checking on - #1
Merged
Merged
Conversation
vite.config.ts carries the org format settings and turns on type-aware linting and type checking. vp test replaces jest, whose ts-jest preset was never installed, so the tests had not run. tsconfig drops the options TypeScript 7 removed (baseUrl, a non-relative paths entry, target es5), sets rootDir to keep the dist layout, and states strict: false and the node types, which TypeScript 7 no longer defaults. dist/ is untouched and excluded from fmt and lint. Sources are reformatted by vp fmt. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GHjaH1Vt2dVLWU68iz8tFq
nyuchi/.github#73 stops setup-node caching in the tool-only jobs, which failed here because packageManager is pinned and there is no lockfile. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GHjaH1Vt2dVLWU68iz8tFq
MD030 (two spaces after the list markers) and MD014 ($ prompts on commands with no output). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GHjaH1Vt2dVLWU68iz8tFq
The reformat made CodeQL report the existing js/redos alert on isValidEmail as new. The rewritten pattern accepts the same language (300,000 random strings agree) without the nested optional quantifier, and addresses over 254 characters (the SMTP limit) are refused before the regex runs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GHjaH1Vt2dVLWU68iz8tFq
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the nyuchi Vite+ rollout (owner approval: pilot in mzizi-dev, then the other orgs). The org-required workflow now publishes
vite-plus / fmt|check|test|build(nyuchi/.github#72, advisory for now).vite-plus^1.0.0 replacesjestand@types/jest.jest.config.jsnamed thets-jestpreset, which was never a dependency, sonpm testfailed before any test ran. The two test files now importexpectandtestfromvite-plus/test, andtestisvp test(9/9 pass).vite.config.tscarries the orgfmtsettings (same values as nyuchi/.github/.oxfmtrc.json) andlint.optionstypeAware+typeCheck.dist/(committed tsc output) is infmtandlintignorePatterns.tsconfig.json:vp checktype checks with TypeScript 7, which rejects four options. Fixes:baseUrlandpathsremoved. They pointed at atypes/directory that does not exist.targetes5 → es2019. ES5 is gone in TypeScript 7, andenginesalready says Node >= 14.rootDir: "src"keeps thedist/index.jslayout.strict: falseandtypes: ["node"]are stated explicitly. TypeScript 7 changed both defaults, and these values are whattsc5.7 has always used here.check/lint/fmtrunvp;buildis unchanged.packageManageris pinned to npm 11.12.1. The lockfile stays gitignored, as upstream has it.vp fmtreformatted the sources, README and.travis.yml. No behaviour change.Note:
dist/is not rebuilt in this PR. The nextnpm run buildwill emit ES2019 instead of ES5.Locally:
vp checkgives 0 errors and 20 warnings (mostlyno-wrapper-object-typesforString, left as is).tsc --noEmitis clean andvp testpasses 9/9.🤖 Generated with Claude Code
https://claude.ai/code/session_01GHjaH1Vt2dVLWU68iz8tFq