Skip to content

ci: stop setup-node caching in the tool-only lint and fmt jobs #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Bryan Fawcett (bryanfawcett) merged 1 commit into from
Oct 2, 2026
Merged

ci: stop setup-node caching in the tool-only lint and fmt jobs #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .github/workflows/reusable-lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,6 +410,12 @@ jobs:
- uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
with:
node-version: '24'
# Node is only a runtime for a globally installed tool here; the
# repo's dependencies are never installed. Without this, a repo
# whose package.json pins packageManager to npm but has no
# lockfile fails the job: setup-node turns on its npm cache and
# finds nothing to key it on.
package-manager-cache: false
- name: Install prettier
env:
PRETTIER_VERSION: ${{ inputs.prettier-version }}
Expand Down Expand Up @@ -529,6 +535,12 @@ jobs:
- uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
with:
node-version: '24'
# Node is only a runtime for a globally installed tool here; the
# repo's dependencies are never installed. Without this, a repo
# whose package.json pins packageManager to npm but has no
# lockfile fails the job: setup-node turns on its npm cache and
# finds nothing to key it on.
package-manager-cache: false
- name: Install markdownlint-cli2
# Deliberately NOT markdownlint-cli2-action. The action pins its
# own bundled markdownlint-cli2, so bumping the action changed the
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/reusable-vite-plus.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,12 @@ jobs:
- uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
with:
node-version: '24'
# Node is only a runtime for a globally installed tool here; the
# repo's dependencies are never installed. Without this, a repo
# whose package.json pins packageManager to npm but has no
# lockfile fails the job: setup-node turns on its npm cache and
# finds nothing to key it on.
package-manager-cache: false
- name: Install the oxfmt that Vite+ bundles
id: install
env:
Expand Down
Loading