Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
vendor/llama.cppfrom5b59b83f4(b11050+1) toa894dae93(b11064), 13 commits.MakefileLLAMA_COMMITfollows the submodule,@version→0.8.53.Compatibility
llama.h,ggml.h,ggml-backend.h,ggml-rpc.h,chat.h,json-schema-to-grammar.h,speculative.h).src/llama-model.cpp/src/llama-context.cppuntouched, sollama_model_default_params/llama_context_default_paramsare unchanged. NIF source untouched.docs/release-guide.mdstill stand (source diff):ggml-cpu/CMakeLists.txt,ggml-cuda.cu, andggml-rpc.cppare absentfrom the range, so the workarounds stay.
Upstream changes worth knowing
</think>used to be classifiedentirely as reasoning and clients saw empty content with no
tool_calls. Gemma 4 required-tool grammar fixed (#29115). PEG parser handles invalid UTF-8 in modeloutput by returning the maximal subpart instead of failing the parse (#29161).
json_schema_to_grammaraccepts an escaped hyphen (\-) in a regexpattern(#29127).LlamaCppEx.Grammar.from_json_schema(%{"type" => "string", "pattern" => "^[a-z\\-]+$"})returned{:error, _}before; it now yields a grammar.dsv4_hc_presupports arbitraryhcinstead of falling back to CPU (#29169, Kimi-K3); FWHT kernel reads F16 input directly (#29094).TOP_K,GEGLU_QUICK, I32GET_ROWS(#29113, #29114, #29116).Verification
macOS (Metal), M1 Max:
mix test(no model)--include smoke --include embeddings --include slow --include mtp--include mtp_sidecar(Qwen3.8-27B-Q4_K_M + mtp-Qwen3.8-27B-Q4_0)LLAMA_BACKEND=cpua894dae93, compiles cleanModels: Qwen3.5-0.8B-UD-Q4_K_XL, Qwen3-Embedding-0.6B-f16, Qwen3.6-35B-A3B-MTP-UD-Q4_K_XL.
rpc_livenot re-run.Throwaway probe against the new NIF for the #29127 fix:
"^[a-z\\-]+$"and"^a\\-b$"both return{:ok, _}with GBNF matching upstream's expected output(
([a-z\-]+),("a\-b")).After merge
triggers precompile → checksum → hex publish.