Fix issue 8012 and 7844 - #8037
Closed
ayushmanchhabra wants to merge 25 commits into
Closed
Conversation
ayushmanchhabra
changed the title
nw.showDevTools on non-sdk buildnw.showDevTools function if called on non-sdk build
ayushmanchhabra
marked this pull request as ready for review
March 7, 2023 08:33
Contributor
Author
|
I was not sure how to test for this behaviour - please let me know if there is a better way to go about it! |
Sanity tests are executed by chromedriver on sdk build flavor. We want to test if showDevTools does not crash NW on execution.
ayushmanchhabra
changed the title
nw.showDevTools function if called on non-sdk buildshowDevTools if called on non-sdk build
ayushmanchhabra
marked this pull request as draft
March 10, 2023 02:29
Check if error is returned before adding it to DOM node's `innerText`
Contributor
Author
|
@rogerwang This is ready for review. Would you be open to backporting these changes to previous versions (nw72 for win 7 and 8)? |
ayushmanchhabra
marked this pull request as ready for review
March 15, 2023 05:59
Contributor
Author
|
@rogerwang would like to get some feedback on this whenever you get the time |
Closed
ayushmanchhabra
marked this pull request as draft
April 4, 2023 20:59
ayushmanchhabra
marked this pull request as ready for review
April 5, 2023 04:46
ayushmanchhabra
changed the title
showDevTools if called on non-sdk build
ayushmanchhabra
marked this pull request as draft
April 18, 2023 00:56
ayushmanchhabra
marked this pull request as ready for review
April 20, 2023 19:30
Contributor
Author
|
@TheJaredWilcurt feel free to update/improve the JSDoc descriptions. I was not sure how to document a callback - maybe you can help out with that? |
Co-authored-by: The Jared Wilcurt <TheJaredWilcurt@users.noreply.github.com>
mjpieters
referenced
this pull request
in pgadmin-org/pgadmin4
Apr 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #8012
Fixes: #7844
The
Window.showDevtoolsfunction crashes since it is not available onnormalflavor. This PR makes the function throw an error which the user can catch in a try/catch block preventing crash.