feat(files): add method OrgHeadline:toggle_tag()#894
Merged
kristijanhusak merged 1 commit intonvim-orgmode:masterfrom Feb 7, 2025
Merged
feat(files): add method OrgHeadline:toggle_tag()#894kristijanhusak merged 1 commit intonvim-orgmode:masterfrom
OrgHeadline:toggle_tag()#894kristijanhusak merged 1 commit intonvim-orgmode:masterfrom
Conversation
Contributor
Author
|
(Unrelated, but thanks for keeping up with this rapid pace of PRs! As a chronic procrastinator, I can imagine it's not easy 👏) |
kristijanhusak
requested changes
Feb 6, 2025
373c447 to
b755f0c
Compare
b755f0c to
aa04d84
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a method
OrgHeadline:toggle_tag().Right now, this simply moves the code of
OrgMappings.toggle_archive_tag()into theOrgHeadlineclass. However, the org-attach module has a feature org_attach_auto_tag, that enables, disables and toggles the tag:ATTACH:when managing attachments. It's used all over the place. (1, 2, 3, 4, 5, 6, 7)Related Issues
Extracted from #878
Changes
OrgHeadline:toggle_tag(tag: string, onoff?: boolean)OrgMappings:toggle_archive_tag()headline_spec.luaChecklist
I confirm that I have:
feat: add new feature,fix: correct bug,docs: update documentation).make test.