Skip to content

Address word segmentation review suggestions#20288

Open
cary-rowen wants to merge 1 commit into
nvaccess:try-chineseWordSegmentation-staging-2from
cary-rowen:try-chineseWordSegmentation-review-followup
Open

Address word segmentation review suggestions#20288
cary-rowen wants to merge 1 commit into
nvaccess:try-chineseWordSegmentation-staging-2from
cary-rowen:try-chineseWordSegmentation-review-followup

Conversation

@cary-rowen
Copy link
Copy Markdown
Contributor

@cary-rowen cary-rowen commented Jun 5, 2026

This PR follows up on #20183 and addresses the latest review suggestions.

  • Rename the local cppjieba wrapper header to use NVDA's usual .h extension.
  • Add a short comment explaining why MSVC warning C4819 is disabled for cppjieba.
  • Casefold braille table names before checking whether a Chinese output table is in use.
  • Reinitialize word segmentation when NVDA configuration is reset.
  • Move the useUniscribe class override lookup out of the concrete OffsetsTextInfo class.
  • Let class-level useUniscribe assignment follow normal attribute-setting behavior when deprecated APIs are disabled.

@cary-rowen cary-rowen requested a review from a team as a code owner June 5, 2026 04:29
@cary-rowen cary-rowen requested review from SaschaCowley and removed request for a team June 5, 2026 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant