Restore Bangla symbol file#20246
Open
CyrilleB79 wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Discussed in this thread.
Fix-up of #19766
Summary of the issue:
In #19766, the Bangla symbol file was removed because it was almost exclusively in English. As a result, punctuation reporting falls back to CLDR.
However, Bangla user prefers English symbol names than CLDR which seems excessively verbose.
Description of user facing changes:
Restored 2025.3.3 Bangla symbol file since it has proven to be useful accross many releases.
Description of developer facing changes:
N/A
Description of development approach:
Testing strategy:
Manual test for characters
'(tick),-(dash) and ". sentence ending" complex symbol.Known issues with pull request:
This PR only restores 2025.3.3 state + adds an obvious fix.
This file should probably be translated further and maybe updated. But this is the job of a Bangla translator that I am not at all. And for now, there isn't actually any NVDA Bangla translator.
Code Review Checklist: