Add ability to extend base only sections#20221
Draft
nvdaes wants to merge 23 commits into
Draft
Conversation
e00d4e9 to
6bbca6f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #7467
Summary of the issue:
Though
CONFIG.CONF.BASE_ONLY_SECTIONSis a public constant intended to be extended of add-ons, this is not really posible without using hacks like resetting the configuration, what can produce side effects.Description of user facing changes:
None.
Description of developer facing changes:
Add-on developers can add sections which Will be applied to the base configuration, not other profiles.
Description of development approach:
addSectionfunction in the ConfigManager class.Testing strategy:
None yet. I plan to add unit tests and test this manually with add-ons.
Known issues with pull request:
None.
Code Review Checklist: