fix: allow i18n multi-sitemap with custom sitemaps #548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When custom sitemaps with `includeAppSources: true` are defined,
expand them to per-locale sitemaps with naming `{locale}-{name}`.
- Check if any custom sitemap has `includeAppSources` before disabling i18n
- Expand includeAppSources sitemaps to `{locale}-{name}` format (e.g., en-pages)
- Each expanded sitemap inherits its parent's exclude/include filters
- Keep non-includeAppSources sitemaps as separate sitemaps
- Update URL filtering to match locale-prefixed sitemap names
- Update docs to document the new behavior
harlan-zw
force-pushed
the
fix/i18n-custom-sitemaps-486
branch
from
a1c00e2 to
d89e2c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Resolves #486
❓ Type of change
📚 Description
Previously, configuring custom
sitemapswould disable automatic i18n multi-sitemap generation entirely. Now sitemaps withincludeAppSources: truehave theirexclude/includefilters merged into the per-locale sitemaps, while other custom sitemaps are kept separate.