fix(tiptap): preserve array/object component props in normalizeProps#477
Closed
hendrikheil wants to merge 0 commit into
Closed
fix(tiptap): preserve array/object component props in normalizeProps#477hendrikheil wants to merge 0 commit into
hendrikheil wants to merge 0 commit into
Conversation
Contributor
|
@hendrikheil is attempting to deploy a commit to the Nuxt Team on Vercel. A member of the Team first needs to authorize it. |
commit: |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
normalizePropsinsrc/app/src/utils/tiptap/props.tswas callingString(value).trim()on every prop value, turning arrays of objects (e.g. YAMLauthorsOne: [{name: 'John', role: 'contributor'}]) into"[object Object],[object Object]"during the comark → Tiptap → comark round-tripobject,array, andnullvalues through unchanged; primitives are still stringified as beforecreateParagraphElementparameter type to match the widened return typeFixes #457.
Reproduction
Open the docus playground on
mainand edit the/authorspage in Studio — saving the page will corrupt the YAML array-of-objects props to inline JSON.Root cause
When a component uses YAML block props with array-of-object values:
The round-trip through the Studio editor would destroy the arrays, serialising them to inline JSON props instead of preserving the YAML block format.
Test plan
normalizePropscovering array-of-objects, plain objects, array-of-primitives, null, and className